[ 
https://issues.apache.org/jira/browse/YARN-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jian He updated YARN-1368:
--------------------------

    Attachment: YARN-1368.3.patch

Thanks Wangda for the review ! the new patch fixed the comments also.
bq. Should we change Resource(1024, 1) to its actually resource?
fixed
bq. For recoverContainersOnNode, is it possible NODE_ADDED happened before 
APP_ADDED?
Not possible, APP_ADDED happens synchronously before ResourceTrackerService is 
started.
bq. It may better to use two parameter assertEquals, because delta is 0
because they are two doubles. fixed the delta value to be 1e-8
bq. Why use split AMContainerCrashedTransition to two transitions and set their 
states to RUNNING/LAUNCHED differently.
To capture completed containers at RUNNING/LAUNCHED state and reuse the common 
code.

> Common work to re-populate containers’ state into scheduler
> -----------------------------------------------------------
>
>                 Key: YARN-1368
>                 URL: https://issues.apache.org/jira/browse/YARN-1368
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Bikas Saha
>            Assignee: Jian He
>         Attachments: YARN-1368.1.patch, YARN-1368.2.patch, YARN-1368.3.patch, 
> YARN-1368.combined.001.patch, YARN-1368.preliminary.patch
>
>
> YARN-1367 adds support for the NM to tell the RM about all currently running 
> containers upon registration. The RM needs to send this information to the 
> schedulers along with the NODE_ADDED_EVENT so that the schedulers can recover 
> the current allocation state of the cluster.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to