Varun Vasudev commented on YARN-2049:

Couple of things -
1. In the function managementOperation, should there be a null check for token?
2. In the function managementOperation, you call secretManager.cancelToken(dt, 
UserGroupInformation.getCurrentUser().getUserName()) - should you use 
getCurrentuser().getUserName? or ownerUGI.getUserName()? The reason I ask is 
that when creating the token, you're using ownerUGI.

> Delegation token stuff for the timeline sever
> ---------------------------------------------
>                 Key: YARN-2049
>                 URL: https://issues.apache.org/jira/browse/YARN-2049
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>         Attachments: YARN-2049.1.patch, YARN-2049.2.patch, YARN-2049.3.patch, 
> YARN-2049.4.patch, YARN-2049.5.patch

This message was sent by Atlassian JIRA

Reply via email to