[ 
https://issues.apache.org/jira/browse/YARN-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14006646#comment-14006646
 ] 

Wangda Tan commented on YARN-1368:
----------------------------------

[~jianhe],
Thanks for addressing my comments, I've looked at your latest patch, only some 
minor comments
1) yarn_server_common_service_protos.proto:
{code}
+  repeated ContainerRecoveryReportProto container_report = 6;
{code}
should be container_reports

2) AppSchedulingInfo.java:
{code}
+    if (containerId >= containerIdCounter.get()) {
+      containerIdCounter.set(containerId);
+    }
{code}
Better to use compareAndSet in a while loop in case of race condition

3) It's better to add a test  for ContainerRecoveryReport

> Common work to re-populate containers’ state into scheduler
> -----------------------------------------------------------
>
>                 Key: YARN-1368
>                 URL: https://issues.apache.org/jira/browse/YARN-1368
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Bikas Saha
>            Assignee: Jian He
>         Attachments: YARN-1368.1.patch, YARN-1368.2.patch, YARN-1368.3.patch, 
> YARN-1368.combined.001.patch, YARN-1368.preliminary.patch
>
>
> YARN-1367 adds support for the NM to tell the RM about all currently running 
> containers upon registration. The RM needs to send this information to the 
> schedulers along with the NODE_ADDED_EVENT so that the schedulers can recover 
> the current allocation state of the cluster.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to