[ 
https://issues.apache.org/jira/browse/YARN-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14006682#comment-14006682
 ] 

Sandy Ryza commented on YARN-2073:
----------------------------------

{code}
+  /** Preemption related variables */
{code}
Nit: use "//" like the other comments.

Can you add the new property in the Fair Scheduler doc?

{code}
+      updateRootQueueMetrics();
{code}
My understanding is that this shouldn't be needed in shouldAttemptPreemption.  
Have you observed otherwise?

Would it be possible to move the TestFairScheduler refactoring to a separate 
JIRA?  If it's too difficult to entangle at this point, I'm ok with it.

> FairScheduler starts preempting resources even with free resources on the 
> cluster
> ---------------------------------------------------------------------------------
>
>                 Key: YARN-2073
>                 URL: https://issues.apache.org/jira/browse/YARN-2073
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: scheduler
>    Affects Versions: 2.4.0
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>            Priority: Critical
>         Attachments: yarn-2073-0.patch, yarn-2073-1.patch, yarn-2073-2.patch, 
> yarn-2073-3.patch
>
>
> Preemption should kick in only when the currently available slots don't match 
> the request. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to