Zhijie Shen commented on YARN-1936:

Vinod, thanks for review. See my response bellow:

bq. Make the event-put as one of the options "-put"

Good point. I make use of CommandLine to do simple CLI.

bq. Add delegation token only if timeline-service is enabled.

Added the check

bq. Also move this main to TimelineClientImpl


bq. selectToken() can use a TimelineDelegationTokenSelector to find the token?

Use selector instead, and do some refactoring required.

bq. Can we add a simple test to validate the addition of the Delegation Token 
to the client credentials?

Added a test case

> Secured timeline client
> -----------------------
>                 Key: YARN-1936
>                 URL: https://issues.apache.org/jira/browse/YARN-1936
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>         Attachments: YARN-1936.1.patch, YARN-1936.2.patch, YARN-1936.3.patch
> TimelineClient should be able to talk to the timeline server with kerberos 
> authentication or delegation token

This message was sent by Atlassian JIRA

Reply via email to