[ 
https://issues.apache.org/jira/browse/YARN-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14007338#comment-14007338
 ] 

Karthik Kambatla commented on YARN-2096:
----------------------------------------

Looks good to me. +1. 

> Race in TestRMRestart#testQueueMetricsOnRMRestart
> -------------------------------------------------
>
>                 Key: YARN-2096
>                 URL: https://issues.apache.org/jira/browse/YARN-2096
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Anubhav Dhoot
>            Assignee: Anubhav Dhoot
>         Attachments: YARN-2096.patch
>
>
> org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart.testQueueMetricsOnRMRestart
>  fails randomly because of a race condition.
> The test validates that metrics are incremented, but does not wait for all 
> transitions to finish before checking for the values.
> It also resets metrics after kicking off recovery of second RM. The metrics 
> that need to be incremented race with this reset causing test to fail 
> randomly.
> We need to wait for the right transitions.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to