Anubhav Dhoot commented on YARN-1366:

Looks good overall, some minor comments below

In AMRMClientImpl, populatePendingReleaseRequests could be renamed to 
removePendingReleaseRequests as its removing them.
We can comment why we need blacklistedNodes in addition to blacklistAdditions 
and removals.
In testRMContainerOnResync there is an unused assignment to "assigned". Also 
might be a good idea to rename the test to indicate what is the condition and 
the expected result, say testRMContainerResendsRequestsOnRestart?
Also it will be to good to test the pendingRelease in TestRMContainerAllocator, 
maybe add 


> ApplicationMasterService should Resync with the AM upon allocate call after 
> restart
> -----------------------------------------------------------------------------------
>                 Key: YARN-1366
>                 URL: https://issues.apache.org/jira/browse/YARN-1366
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Bikas Saha
>            Assignee: Rohith
>         Attachments: YARN-1366.1.patch, YARN-1366.2.patch, YARN-1366.3.patch, 
> YARN-1366.patch, YARN-1366.prototype.patch, YARN-1366.prototype.patch
> The ApplicationMasterService currently sends a resync response to which the 
> AM responds by shutting down. The AM behavior is expected to change to 
> calling resyncing with the RM. Resync means resetting the allocate RPC 
> sequence number to 0 and the AM should send its entire outstanding request to 
> the RM. Note that if the AM is making its first allocate call to the RM then 
> things should proceed like normal without needing a resync. The RM will 
> return all containers that have completed since the RM last synced with the 
> AM. Some container completions may be reported more than once.

This message was sent by Atlassian JIRA

Reply via email to