[
https://issues.apache.org/jira/browse/YARN-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14013325#comment-14013325
]
Hadoop QA commented on YARN-2103:
---------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12647536/YARN-2103.v2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3864//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3864//console
This message is automatically generated.
> Inconsistency between viaProto flag and initial value of
> SerializedExceptionProto.Builder
> -----------------------------------------------------------------------------------------
>
> Key: YARN-2103
> URL: https://issues.apache.org/jira/browse/YARN-2103
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Binglin Chang
> Assignee: Binglin Chang
> Attachments: YARN-2103.v1.patch, YARN-2103.v2.patch
>
>
> Bug 1:
> {code}
> SerializedExceptionProto proto = SerializedExceptionProto
> .getDefaultInstance();
> SerializedExceptionProto.Builder builder = null;
> boolean viaProto = false;
> {code}
> Since viaProto is false, we should initiate build rather than proto
> Bug 2:
> the class does not provide hashcode() and equals() like other PBImpl records,
> this class is used in other records, it may affect other records' behavior.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
