Jian He commented on YARN-1368:

bq.Kill container? Same for the following too?
good point,fixed.
bq. Instead we should use getCurrentAttemptForContainer(ContainerId 
I think the RMContainer should be created with the original attempt Id. The 
containerId to attemptId routing will happen automatically.
bq. ContainerRecoveredTransition: Missing other transitions that a regular 
container goes through?
checked the code, we only need to send event to update the ranNodes. Added 
here. Eventually, YARN-1885 should fix the ranNodes thing on recovery.
bq. Kill the container when the following happens?
I added comment saying this condition can never happen.

> Common work to re-populate containers’ state into scheduler
> -----------------------------------------------------------
>                 Key: YARN-1368
>                 URL: https://issues.apache.org/jira/browse/YARN-1368
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Bikas Saha
>            Assignee: Jian He
>         Attachments: YARN-1368.1.patch, YARN-1368.2.patch, YARN-1368.3.patch, 
> YARN-1368.4.patch, YARN-1368.5.patch, YARN-1368.7.patch, 
> YARN-1368.combined.001.patch, YARN-1368.preliminary.patch
> YARN-1367 adds support for the NM to tell the RM about all currently running 
> containers upon registration. The RM needs to send this information to the 
> schedulers along with the NODE_ADDED_EVENT so that the schedulers can recover 
> the current allocation state of the cluster.

This message was sent by Atlassian JIRA

Reply via email to