[ 
https://issues.apache.org/jira/browse/YARN-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014539#comment-14014539
 ] 

Zhijie Shen commented on YARN-2118:
-----------------------------------

The fix looks good to me, but would you mind adding a test case that the user 
post an entity that contains the system filter, and gets rejected?

> Type mismatch in contains() check of TimelineWebServices#injectOwnerInfo()
> --------------------------------------------------------------------------
>
>                 Key: YARN-2118
>                 URL: https://issues.apache.org/jira/browse/YARN-2118
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: yarn-2118-v1.txt
>
>
> {code}
>     if (timelineEntity.getPrimaryFilters() != null &&
>         timelineEntity.getPrimaryFilters().containsKey(
>             TimelineStore.SystemFilter.ENTITY_OWNER)) {
>       throw new YarnException(
> {code}
> getPrimaryFilters() returns a Map keyed by String.
> However, TimelineStore.SystemFilter.ENTITY_OWNER is an enum.
> Their types don't match.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to