[ 
https://issues.apache.org/jira/browse/YARN-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14016097#comment-14016097
 ] 

Robert Kanter commented on YARN-2122:
-------------------------------------

Findbugs is complaining that the three methods are no synchronized.  This isn't 
a problem because all three methods have a javadoc comment in AbstractService 
that says something like this:
{noformat}
   * This method will only ever be called once during the lifecycle of
   * a specific service instance.
   *
   * Implementations do not need to be synchronized as the logic
   * in {@link #init(Configuration)} prevents re-entrancy.
{noformat}

> In AllocationFileLoaderService, the reloadThread should be created in init() 
> and started in start()
> ---------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2122
>                 URL: https://issues.apache.org/jira/browse/YARN-2122
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: scheduler
>    Affects Versions: 2.4.0
>            Reporter: Karthik Kambatla
>            Assignee: Robert Kanter
>         Attachments: YARN-2122.patch, YARN-2122.patch
>
>
> AllcoationFileLoaderService has this reloadThread that is currently created 
> and started in start(). Instead, it should be created in init() and started 
> in start().



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to