[ https://issues.apache.org/jira/browse/YARN-2130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020231#comment-14020231 ]
Chen He commented on YARN-2130: ------------------------------- [~ozawa], thank you for the patch. minor issue that I can find: indent is breaking {code} - this.rmAppManager, this.applicationACLsManager, this.queueACLsManager, - this.getRMContext().getRMDelegationTokenSecretManager()); + this.getRMContext().getRMAppManager(), + this.getRMContext().getApplicationACLsManager(), + this.getRMContext().getQueueACLsManager(), + this.getRMContext().getRMDelegationTokenSecretManager()); return new ClientRMService(this.rmContext, scheduler, - this.rmAppManager, this.applicationACLsManager, this.queueACLsManager, - this.getRMContext().getRMDelegationTokenSecretManager()); + this.getRMContext().getRMAppManager(), + this.getRMContext().getApplicationACLsManager(), + this.getRMContext().getQueueACLsManager(), + this.getRMContext().getRMDelegationTokenSecretManager()); {code} > Cleanup: Adding getRMAppManager, getQueueACLsManager, > getApplicationACLsManager to RMContext > -------------------------------------------------------------------------------------------- > > Key: YARN-2130 > URL: https://issues.apache.org/jira/browse/YARN-2130 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Reporter: Tsuyoshi OZAWA > Assignee: Tsuyoshi OZAWA > Attachments: YARN-2130.1.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)