Tsuyoshi OZAWA commented on YARN-2130:

[~airbots], thank you for the comment. IIUC, they are correct indent.  [The 
Hadoop code review 
checklist|https://wiki.apache.org/hadoop/CodeReviewChecklist] says "new code 
follows Sun's code conventions except indentation is 2 spaces, not 4". Also, 
[Sun's code 
 says that "If the above rules lead to confusing code or to code that's 
squished up against the right margin, just indent 8 spaces instead." We use 2 
spaces style, so 4 indent in this case is correct. Please let me know if I'm 
wrong. Thanks!

> Cleanup: Adding getRMAppManager, getQueueACLsManager, 
> getApplicationACLsManager to RMContext
> --------------------------------------------------------------------------------------------
>                 Key: YARN-2130
>                 URL: https://issues.apache.org/jira/browse/YARN-2130
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Tsuyoshi OZAWA
>            Assignee: Tsuyoshi OZAWA
>         Attachments: YARN-2130.1.patch

This message was sent by Atlassian JIRA

Reply via email to