[ 
https://issues.apache.org/jira/browse/YARN-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020782#comment-14020782
 ] 

Hudson commented on YARN-2128:
------------------------------

FAILURE: Integrated in Hadoop-Yarn-trunk #576 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk/576/])
YARN-2128. FairScheduler: Incorrect calculation of amResource usage. (Wei Yan 
via kasha) (kasha: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1601050)
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApplicationAttempt.java
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/AppSchedulable.java
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSLeafQueue.java
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairScheduler.java
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestFairScheduler.java


> FairScheduler: Incorrect calculation of amResource usage
> --------------------------------------------------------
>
>                 Key: YARN-2128
>                 URL: https://issues.apache.org/jira/browse/YARN-2128
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Wei Yan
>            Assignee: Wei Yan
>             Fix For: 2.5.0
>
>         Attachments: YARN-2128.patch, YARN-2128.patch
>
>
> 1. The amResource should be normalized instead of fetching from 
> ApplicationSubmissionContext directly.
> {code}
>     ApplicationSubmissionContext appSubmissionContext =
>         rmContext.getRMApps().get(applicationAttemptId.getApplicationId())
>             .getApplicationSubmissionContext();
>     if (appSubmissionContext != null) {
>         amResource = appSubmissionContext.getResource();
>         unmanagedAM = appSubmissionContext.getUnmanagedAM();
>     }
> {code}
> 2. When one application is removed, the FSLeafQueue's amResourceUsage should 
> be updated only if the app has started its AM.
> {code}
>   if (runnableAppScheds.remove(app.getAppSchedulable())) {
>       // Update AM resource usage
>       if (app.getAMResource() != null) {
>         Resources.subtractFrom(amResourceUsage, app.getAMResource());
>       }
>       return true;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to