[ https://issues.apache.org/jira/browse/YARN-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020836#comment-14020836 ]
Hudson commented on YARN-2117: ------------------------------ FAILURE: Integrated in Hadoop-Mapreduce-trunk #1794 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1794/]) YARN-2117. Fixed the issue that secret file reader is potentially not closed in TimelineAuthenticationFilterInitializer. Contributed by Chen He. (zjshen: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1600994) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/security/TimelineAuthenticationFilterInitializer.java > Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() > should be enclosed in finally block > ----------------------------------------------------------------------------------------------------------- > > Key: YARN-2117 > URL: https://issues.apache.org/jira/browse/YARN-2117 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Ted Yu > Assignee: Chen He > Priority: Minor > Labels: newbie > Fix For: 2.5.0 > > Attachments: YARN-2117-v2.patch, YARN-2117.patch > > > Here is related code: > {code} > Reader reader = new FileReader(signatureSecretFile); > int c = reader.read(); > while (c > -1) { > secret.append((char) c); > c = reader.read(); > } > reader.close(); > {code} > If IOException is thrown out of reader.read(), reader would be left unclosed. -- This message was sent by Atlassian JIRA (v6.2#6252)