[ 
https://issues.apache.org/jira/browse/YARN-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14023411#comment-14023411
 ] 

Hadoop QA commented on YARN-2134:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12648977/YARN-2134.diff
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 2 
warning messages.
        See 
https://builds.apache.org/job/PreCommit-YARN-Build/3941//artifact/trunk/patchprocess/diffJavadocWarnings.txt
 for details.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/3941//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3941//console

This message is automatically generated.

> FairSchduler AllocationConfiguration doesn't treat hierarchical queues 
> settings
> -------------------------------------------------------------------------------
>
>                 Key: YARN-2134
>                 URL: https://issues.apache.org/jira/browse/YARN-2134
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>    Affects Versions: 2.5.0
>            Reporter: Andrey Stepachev
>         Attachments: YARN-2134.diff, broken-hier-queues.diff
>
>
> AllocationConfiguration doesn't fully qualify queue names with respect to 
> 'root.' prefix. Such behaviour leads to situation where settings for nested 
> queue doesn't take effect. 
> Consider following config (working example in broken-hier-queues.diff 
> attached) sub queue settings were not applied by method 
> queueConf.getMaxResources.
> {code:xml}
> <queue name="queueA">
> <maxResources>2048mb,10vcores</maxResources>
> <queue name="queueB">
> <maxResources>512mb,1vcores</maxResources>
> </queue>
> </queue>
> {code}
> I made patch, which unifies QueueName operations (remove those indexOf copy 
> pastes) and apply some of settings in hierarchical manner  (say preemption 
> timeout can be used from parent queue instead of global default).
> Also it is interesting to introduce type safe object QueueName and replace 
> String in interfaces, and I have made an attempt 
> (https://github.com/octo47/hadoop-common/tree/feature/octo/fs-queue-name), 
> but looks like it lead to some inconsitancy and I think that it is not 
> necessary right now).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to