[ 
https://issues.apache.org/jira/browse/YARN-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Vasudev updated YARN-1702:
--------------------------------

    Attachment: apache-yarn-1702.12.patch

Uploaded new patch addressing comments.

{quote}
AppInfo.java changes are unnecessary.
{quote}

Fixed.

{quote}
*  rm.getClientRMService().forceKillApplication(req) already does the auth 
stuff, no need to duplicate it in web-services?
*  hasQueueAcess() is not used anywhere.
{quote}

Fixed. The web services code unwraps the exception and checks if it is an 
access exception and if so bubbles it up. hasQueueAccess() has been remove.

{quote}
We can share code between getNoAuthInjector(), getSimpleAuthInjector()
{quote}

Fixed.

{quote}
The following is not needed? 
{noformat}
    // there's a condition where if the rm is stopped while an app
    // is being killed, it can lead to the test timing out, hence the sleep
    Thread.sleep(3000);
{noformat}
{quote}

Removed.

> Expose kill app functionality as part of RM web services
> --------------------------------------------------------
>
>                 Key: YARN-1702
>                 URL: https://issues.apache.org/jira/browse/YARN-1702
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Varun Vasudev
>            Assignee: Varun Vasudev
>         Attachments: apache-yarn-1702.10.patch, apache-yarn-1702.11.patch, 
> apache-yarn-1702.12.patch, apache-yarn-1702.2.patch, 
> apache-yarn-1702.3.patch, apache-yarn-1702.4.patch, apache-yarn-1702.5.patch, 
> apache-yarn-1702.7.patch, apache-yarn-1702.8.patch, apache-yarn-1702.9.patch
>
>
> Expose functionality to kill an app via the ResourceManager web services API.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to