[ 
https://issues.apache.org/jira/browse/YARN-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrey Stepachev updated YARN-2145:
-----------------------------------

    Description: 
method fair.FSQueue#assignContainerPreCheck() uses Resources.fitsIn 
incorrectly, because if queue is at its maximum method returns true and 
container can be assigned to queue with maximum resources consumed.
That is because fetsIn code do <= comparison and if allocated resources == max 
resources fitsIn still returns true, and consequently pre check successes
{code}
  public static boolean fitsIn(Resource smaller, Resource bigger) {
    return smaller.getMemory() <= bigger.getMemory() &&
        smaller.getVirtualCores() <= bigger.getVirtualCores();
  }
{code}

  was:
method fair.FSQueue#assignContainerPreCheck() uses Resources.fitsIn 
incorrectly, because if queue is at it maximum method returns true and 
container can be assigned to queue with maximum resources consumed.
That is because fetsIn code do <= comparison and if allocated resources == max 
resources fitsIn still returns true, and consequently pre check successes and 
node have been assigned to overloaded queue.
{code}
  public static boolean fitsIn(Resource smaller, Resource bigger) {
    return smaller.getMemory() <= bigger.getMemory() &&
        smaller.getVirtualCores() <= bigger.getVirtualCores();
  }
{code}


> FairScheduler can assign more resources to queue with MaxShare set.
> -------------------------------------------------------------------
>
>                 Key: YARN-2145
>                 URL: https://issues.apache.org/jira/browse/YARN-2145
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>    Affects Versions: 2.5.0
>            Reporter: Andrey Stepachev
>         Attachments: YARN-2145.diff
>
>
> method fair.FSQueue#assignContainerPreCheck() uses Resources.fitsIn 
> incorrectly, because if queue is at its maximum method returns true and 
> container can be assigned to queue with maximum resources consumed.
> That is because fetsIn code do <= comparison and if allocated resources == 
> max resources fitsIn still returns true, and consequently pre check successes
> {code}
>   public static boolean fitsIn(Resource smaller, Resource bigger) {
>     return smaller.getMemory() <= bigger.getMemory() &&
>         smaller.getVirtualCores() <= bigger.getVirtualCores();
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to