[
https://issues.apache.org/jira/browse/YARN-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14028216#comment-14028216
]
Bikas Saha commented on YARN-2148:
----------------------------------
[~ozawa] Can you please apply this patch and run the full YARN tests. I would
like to make sure that we catch all tests that may have failed due to the
container exit status. I can commit the patch if there are no new tests. Else
we should fix them all in this jira. Thanks!
> TestNMClient failed due more exit code values added and passed to AM
> --------------------------------------------------------------------
>
> Key: YARN-2148
> URL: https://issues.apache.org/jira/browse/YARN-2148
> Project: Hadoop YARN
> Issue Type: Bug
> Components: client
> Affects Versions: 3.0.0, 2.5.0
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Attachments: YARN-2148.patch
>
>
> Currently, TestNMClient will be failed in trunk, see
> https://builds.apache.org/job/PreCommit-YARN-Build/3959/testReport/junit/org.apache.hadoop.yarn.client.api.impl/TestNMClient/testNMClient/
> {code}
> java.lang.AssertionError: null
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at
> org.apache.hadoop.yarn.client.api.impl.TestNMClient.testGetContainerStatus(TestNMClient.java:385)
> at
> org.apache.hadoop.yarn.client.api.impl.TestNMClient.testContainerManagement(TestNMClient.java:347)
> at
> org.apache.hadoop.yarn.client.api.impl.TestNMClient.testNMClient(TestNMClient.java:226)
> {code}
> Test cases in TestNMClient uses following code to verify exit code of
> COMPLETED containers
> {code}
> testGetContainerStatus(container, i, ContainerState.COMPLETE,
> "Container killed by the ApplicationMaster.", Arrays.asList(
> new Integer[] {137, 143, 0}));
> {code}
> But YARN-2091 added logic to make exit code reflecting the actual status, so
> exit code of the "killed by ApplicationMaster" will be -105,
> {code}
> if (container.hasDefaultExitCode()) {
> container.exitCode = exitEvent.getExitCode();
> }
> {code}
> We should update test case as well.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
