[jira] [Commented] (YARN-1885) RM may not send the finished signal to some nodes where the application ran after RM restarts

[Jian He (JIRA)]

    [ 
https://issues.apache.org/jira/browse/YARN-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14028792#comment-14028792
 ] 

Jian He commented on YARN-1885:
-------------------------------

Some minor comments:
 we can use container.nodeId
{code}
        container.eventHandler.handle(new RMAppNodeAddedEvent(container
            .getApplicationAttemptId().getApplicationId(), container
            .getContainer().getNodeId()));
{code}
 the comment should be changed to app as well.
{code}
// Tell the appAttempt
{code}
 TestResourceTrackerService import only changes, can be reverted 

we can use app.handler
{code}
app.dispatcher.getEventHandler().handle(
{code}

Is this an existing bug? reconnected event is sent to the NEW node instead of 
the old node. we can fix this separately, if this is.
{code}
    RMNode oldNode = this.rmContext.getRMNodes().putIfAbsent(nodeId, rmNode);
    if (oldNode == null) {
      this.rmContext.getDispatcher().getEventHandler().handle(
              new RMNodeStartedEvent(nodeId, request.getNMContainerStatuses(),
                  request.getRunningApplications()));
    } else {
      LOG.info("Reconnect from the node at: " + host);
      this.nmLivelinessMonitor.unregister(nodeId);
      this.rmContext.getDispatcher().getEventHandler().handle(
          new RMNodeReconnectEvent(nodeId, rmNode));
    }
{code}

> RM may not send the finished signal to some nodes where the application ran 
> after RM restarts
> ---------------------------------------------------------------------------------------------
>
>                 Key: YARN-1885
>                 URL: https://issues.apache.org/jira/browse/YARN-1885
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.4.0
>            Reporter: Arpit Gupta
>            Assignee: Wangda Tan
>         Attachments: YARN-1885.patch, YARN-1885.patch, YARN-1885.patch, 
> YARN-1885.patch, YARN-1885.patch, YARN-1885.patch
>
>
> During our HA testing we have seen cases where yarn application logs are not 
> available through the cli but i can look at AM logs through the UI. RM was 
> also being restarted in the background as the application was running.



--
This message was sent by Atlassian JIRA
(v6.2#6252)