Jian He commented on YARN-1885:

Some minor comments:
 we can use container.nodeId
        container.eventHandler.handle(new RMAppNodeAddedEvent(container
            .getApplicationAttemptId().getApplicationId(), container
 the comment should be changed to app as well.
// Tell the appAttempt
 TestResourceTrackerService import only changes, can be reverted 

we can use app.handler

Is this an existing bug? reconnected event is sent to the NEW node instead of 
the old node. we can fix this separately, if this is.
    RMNode oldNode = this.rmContext.getRMNodes().putIfAbsent(nodeId, rmNode);
    if (oldNode == null) {
              new RMNodeStartedEvent(nodeId, request.getNMContainerStatuses(),
    } else {
      LOG.info("Reconnect from the node at: " + host);
          new RMNodeReconnectEvent(nodeId, rmNode));

> RM may not send the finished signal to some nodes where the application ran 
> after RM restarts
> ---------------------------------------------------------------------------------------------
>                 Key: YARN-1885
>                 URL: https://issues.apache.org/jira/browse/YARN-1885
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.4.0
>            Reporter: Arpit Gupta
>            Assignee: Wangda Tan
>         Attachments: YARN-1885.patch, YARN-1885.patch, YARN-1885.patch, 
> YARN-1885.patch, YARN-1885.patch, YARN-1885.patch
> During our HA testing we have seen cases where yarn application logs are not 
> available through the cli but i can look at AM logs through the UI. RM was 
> also being restarted in the background as the application was running.

This message was sent by Atlassian JIRA

Reply via email to