[ 
https://issues.apache.org/jira/browse/YARN-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14031368#comment-14031368
 ] 

Hadoop QA commented on YARN-2159:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12650415/YARN2159-01.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/3987//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3987//console

This message is automatically generated.

> allocateContainer() in SchedulerNode needs a clearer LOG.info message
> ---------------------------------------------------------------------
>
>                 Key: YARN-2159
>                 URL: https://issues.apache.org/jira/browse/YARN-2159
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>            Reporter: Ray Chiang
>            Assignee: Ray Chiang
>            Priority: Minor
>              Labels: supportability
>         Attachments: YARN2159-01.patch
>
>
> This bit of code:
> {quote}
>     LOG.info("Assigned container " + container.getId() + " of capacity "
>         + container.getResource() + " on host " + rmNode.getNodeAddress()
>         + ", which currently has " + numContainers + " containers, "
>         + getUsedResource() + " used and " + getAvailableResource()
>         + " available");
> {quote}
> results in a line like:
> {quote}
> 2014-05-30 16:17:43,573 INFO 
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSSchedulerNode: 
> Assigned container container_1400666605555_0009_01_001111 of capacity 
> <memory:1536, vCores:1> on host machine.host.domain.com:8041, which currently 
> has 18 containers, <memory:27648, vCores:18> used and <memory:3072, vCores:0> 
> available
> {quote}
> That message is fine in most cases, but looks pretty bad after the last 
> available allocation, since it says something like "vCores:0 available".
> Here is one suggested phrasing
>   - "which has 18 containers, <memory:27648, vCores:18> used and 
> <memory:3072, vCores:0> available after allocation"



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to