Thomas Graves commented on YARN-2072:

Thanks Nathan, it mostly looks good. A few comments:

- In the UserMetricsInfo getReservedVirtualCores is returning 
allocatedVirtualCores and should be returning reservedVirtualCores
- In MetricsOverviewTable you should capitalize the C in "Vcores Reserved" 

The only other thing is if we want to do something special if the 
DominantResourceCalculator isn't being used. Right now with the 
capacityScheduler and FifoScheduler it ends up showings it using 1 vcore per 
container.  The fairscheduler reports what the user would be using but I 
believe doesn't enforce it.   The fairscheduler reporting seems more intuitive 
so perhaps we should change the capacityscheduler/fifo to do similar reporting. 
 I think that would be a follow up jira though.

Sandy, do you have any comments on this about how it shows up with 

> RM/NM UIs and webservices are missing vcore information
> -------------------------------------------------------
>                 Key: YARN-2072
>                 URL: https://issues.apache.org/jira/browse/YARN-2072
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager, resourcemanager, webapp
>    Affects Versions: 3.0.0, 2.4.0
>            Reporter: Nathan Roberts
>            Assignee: Nathan Roberts
>         Attachments: YARN-2072.patch
> Change RM and NM UIs and webservices to include virtual cores.

This message was sent by Atlassian JIRA

Reply via email to