[ 
https://issues.apache.org/jira/browse/YARN-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036735#comment-14036735
 ] 

Junping Du commented on YARN-2088:
----------------------------------

I think we should just simply call "builder.clear()" instead of clearing each 
property individually. [~decster], can you just apply this one line change 
(with removing some clearing individual properties) and your unit test. Other 
code is convention change and we can do it separately (with other PBImpl 
together)?

> Fix code bug in GetApplicationsRequestPBImpl#mergeLocalToBuilder
> ----------------------------------------------------------------
>
>                 Key: YARN-2088
>                 URL: https://issues.apache.org/jira/browse/YARN-2088
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>         Attachments: YARN-2088.v1.patch
>
>
> Some fields(set,list) are added to proto builders many times, we need to 
> clear those fields before add, otherwise the result proto contains more 
> contents.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to