[ 
https://issues.apache.org/jira/browse/YARN-2130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037838#comment-14037838
 ] 

Karthik Kambatla commented on YARN-2130:
----------------------------------------

Looking even better. Few more comments:
# Like how the ClientRMService's constructor is minimal. We should probably do 
the same to RMAppManager and ResourceTrackerService.
# What do you think of leaving the fields in ClientRMService and initializing 
them in the constructor? That way, the changes would be limited to 
constructors. 

> Cleanup: Adding getRMAppManager, getQueueACLsManager, 
> getApplicationACLsManager to RMContext
> --------------------------------------------------------------------------------------------
>
>                 Key: YARN-2130
>                 URL: https://issues.apache.org/jira/browse/YARN-2130
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Tsuyoshi OZAWA
>            Assignee: Tsuyoshi OZAWA
>         Attachments: YARN-2130.1.patch, YARN-2130.2.patch, YARN-2130.3.patch, 
> YARN-2130.4.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to