[ 
https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14040328#comment-14040328
 ] 

Jian He commented on YARN-2144:
-------------------------------

The first check can never happen?
{code}
    if (null == attemptId) {
      return;
    }
{code}
Please add logs also if app/attempt equals to null.
{code}
    if (null == app) {
      return;
    }
    if (null == attempt) {
      return;
    }
{code}

> Add logs when preemption occurs
> -------------------------------
>
>                 Key: YARN-2144
>                 URL: https://issues.apache.org/jira/browse/YARN-2144
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: capacityscheduler
>    Affects Versions: 2.5.0
>            Reporter: Tassapol Athiapinya
>            Assignee: Wangda Tan
>         Attachments: AM-page-preemption-info.png, YARN-2144.patch, 
> YARN-2144.patch, YARN-2144.patch, YARN-2144.patch, YARN-2144.patch, 
> YARN-2144.patch
>
>
> There should be easy-to-read logs when preemption does occur. 
> RM logs should have following properties:
> * Logs are retrievable when an application is still running and often flushed.
> * Can distinguish between AM container preemption and task container 
> preemption with container ID shown.
> * Should be INFO level log.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to