[ https://issues.apache.org/jira/browse/YARN-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14040444#comment-14040444 ]
Hadoop QA commented on YARN-2191: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12651923/YARN-2191.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: org.apache.hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps org.apache.hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRMRPCNodeUpdates {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/4044//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4044//console This message is automatically generated. > Add a test to make sure NM will do application cleanup even if RM restarting > happens before application completed > ----------------------------------------------------------------------------------------------------------------- > > Key: YARN-2191 > URL: https://issues.apache.org/jira/browse/YARN-2191 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager > Affects Versions: 2.4.0 > Reporter: Wangda Tan > Assignee: Wangda Tan > Attachments: YARN-2191.patch, YARN-2191.patch > > > In YARN-1885, there's a test in > TestApplicationCleanup#testAppCleanupWhenRestartedAfterAppFinished. However, > we need one more test to make sure NM will do app cleanup when restart > happens before app finished. The sequence is, > 1. Submit app1 to RM1 > 2. NM1 launches app1's AM (container-0), NM2 launches app1's task containers. > 3. Restart RM1 > 4. Before RM1 finishes restarting, container-0 completed in NM1 > 5. RM1 finishes restarting, NM1 report container-0 completed, app1 will be > completed > 6. RM1 should be able to notify NM1/NM2 to cleanup app1. -- This message was sent by Atlassian JIRA (v6.2#6252)