Jian He commented on YARN-2181:

- how about the parent queue metrics, are we capturing preemption metrics only 
at leaf queue? If not, we can add the metrics as part of QueueMetrics class 
which is more flexible.
- CSQueue, FiCaSchedulerApp changes can be reverted.
- if this can be true, the previous queue.getQueueName() will fail upfront. we 
may not need this null check?
if (null != queue) {
- we don’t need isAMContainerPreempted() method.  isPreempted() does the same.
-  these new methods maybe not needed. AppInfo() can just use current attempt 
to access.
- “Did AM Containers Preempted..”: this is transient state and may be not 
- how about the following on 
 -- app page:
Total Resource Preempted
Total Number of AM Containers Preempted
Total Number of Non-AM Containers Preempted
Resource Preempted from Current Attempt
Number of Non-AM Containers Preempted from Current Attempt
-- queue page:
Num AM Containers Preempted
Num Non-AM Containers Preempted

> Add preemption info to RM Web UI
> --------------------------------
>                 Key: YARN-2181
>                 URL: https://issues.apache.org/jira/browse/YARN-2181
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager, webapp
>    Affects Versions: 2.4.0
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-2181.patch, YARN-2181.patch, YARN-2181.patch, 
> YARN-2181.patch, application page.png, queue page.png
> We need add preemption info to RM web page to make administrator/user get 
> more understanding about preemption happened on app/queue, etc. 

This message was sent by Atlassian JIRA

Reply via email to