Daryn Sharp commented on YARN-2147:

Code looks fine.  Currently the test verifies the stringified token is in the 
exception's message.  However since the mock is throwing an exception 
explicitly with the stringified token, we don't know if the code change is 
actually catching and adding the token.  The mock should throw a generic string 
of say, "boom".  Then check the caught exception against something like "Failed 
to renew token: <token>: boom".

> client lacks delegation token exception details when application submit fails
> -----------------------------------------------------------------------------
>                 Key: YARN-2147
>                 URL: https://issues.apache.org/jira/browse/YARN-2147
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.4.0
>            Reporter: Jason Lowe
>            Assignee: Chen He
>            Priority: Minor
>         Attachments: YARN-2147-v2.patch, YARN-2147-v3.patch, 
> YARN-2147-v4.patch, YARN-2147.patch
> When an client submits an application and the delegation token process fails 
> the client can lack critical details needed to understand the nature of the 
> error.  Only the message of the error exception is conveyed to the client, 
> which sometimes isn't enough to debug.

This message was sent by Atlassian JIRA

Reply via email to