[ https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14047962#comment-14047962 ]
Jian He commented on YARN-1366: ------------------------------- Thanks for updating, some more comments: - “blacklistRemovals.addAll(blacklistToRemove);”, we don't need to add this in isResyncCommand check? as RM after restart will just forget all previously blacklisted nodes. - below code needs synchronize ? {code} for (Map<String, TreeMap<Resource, ResourceRequestInfo>> rr : remoteRequestsTable .values()) { for (Map<Resource, ResourceRequestInfo> capabalities : rr.values()) { for (ResourceRequestInfo request : capabalities.values()) { addResourceRequestToAsk(request.remoteRequest); } } } {code} - “isApplicationMasterRegistered = false;” not needed in allocate and unregisterApplicationMaster. - Instead of adding a new core-site.xml file, we can just set the config in the test code conf object. > AM should implement Resync with the ApplicationMasterService instead of > shutting down > ------------------------------------------------------------------------------------- > > Key: YARN-1366 > URL: https://issues.apache.org/jira/browse/YARN-1366 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Reporter: Bikas Saha > Assignee: Rohith > Attachments: YARN-1366.1.patch, YARN-1366.2.patch, YARN-1366.3.patch, > YARN-1366.4.patch, YARN-1366.5.patch, YARN-1366.6.patch, YARN-1366.7.patch, > YARN-1366.8.patch, YARN-1366.patch, YARN-1366.prototype.patch, > YARN-1366.prototype.patch > > > The ApplicationMasterService currently sends a resync response to which the > AM responds by shutting down. The AM behavior is expected to change to > calling resyncing with the RM. Resync means resetting the allocate RPC > sequence number to 0 and the AM should send its entire outstanding request to > the RM. Note that if the AM is making its first allocate call to the RM then > things should proceed like normal without needing a resync. The RM will > return all containers that have completed since the RM last synced with the > AM. Some container completions may be reported more than once. -- This message was sent by Atlassian JIRA (v6.2#6252)