Jian He commented on YARN-1366:

-  SecurityUtil.java loads configurations during class loading.
I see. 

Patch looks good to me, just two more minor comments:
- These two synchronized block can be merged into one ?
        synchronized (this) {
          // reset lastResponseId to 0
          lastResponseId = 0;
        // re register with RM

        synchronized (this) {
          for (Map<String, TreeMap<Resource, ResourceRequestInfo>> rr : 
              .values()) {
            for (Map<Resource, ResourceRequestInfo> capabalities : rr.values()) 
              for (ResourceRequestInfo request : capabalities.values()) {
- The following reset of responseId in unregisterApplicationMaster is not 
      synchronized (this) {
        // reset lastResponseId to 0
        lastResponseId = 0;

> AM should implement Resync with the ApplicationMasterService instead of 
> shutting down
> -------------------------------------------------------------------------------------
>                 Key: YARN-1366
>                 URL: https://issues.apache.org/jira/browse/YARN-1366
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Bikas Saha
>            Assignee: Rohith
>         Attachments: YARN-1366.1.patch, YARN-1366.2.patch, YARN-1366.3.patch, 
> YARN-1366.4.patch, YARN-1366.5.patch, YARN-1366.6.patch, YARN-1366.7.patch, 
> YARN-1366.8.patch, YARN-1366.9.patch, YARN-1366.patch, 
> YARN-1366.prototype.patch, YARN-1366.prototype.patch
> The ApplicationMasterService currently sends a resync response to which the 
> AM responds by shutting down. The AM behavior is expected to change to 
> calling resyncing with the RM. Resync means resetting the allocate RPC 
> sequence number to 0 and the AM should send its entire outstanding request to 
> the RM. Note that if the AM is making its first allocate call to the RM then 
> things should proceed like normal without needing a resync. The RM will 
> return all containers that have completed since the RM last synced with the 
> AM. Some container completions may be reported more than once.

This message was sent by Atlassian JIRA

Reply via email to