[ 
https://issues.apache.org/jira/browse/YARN-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050042#comment-14050042
 ] 

Zhijie Shen commented on YARN-2233:
-----------------------------------

Almost good to me. Just some nits:

1. This won't happen inside renewDelegationToken, as it is already validated 
before.
{code}
+    if (tokenData.getToken().isEmpty()) {
+      throw new BadRequestException("Empty token in request");
+    }
{code}

2. It seems that some of the fields in DelegationToken are no longer necessary.

3. assertValidToken seems not to be necessary.

> Implement web services to create, renew and cancel delegation tokens
> --------------------------------------------------------------------
>
>                 Key: YARN-2233
>                 URL: https://issues.apache.org/jira/browse/YARN-2233
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Varun Vasudev
>            Assignee: Varun Vasudev
>            Priority: Blocker
>         Attachments: apache-yarn-2233.0.patch, apache-yarn-2233.1.patch
>
>
> Implement functionality to create, renew and cancel delegation tokens.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to