zhihai xu commented on YARN-2254:

Karthik- Sorry, I am busy last several days. I get time to work on this issue 
Your suggestion is really good, I already see the benefits now.
A new test (testAppSubmit) is added recently(after I submit patch on 07/04).
This new test(testAppSubmit) is failed with FairScheduler at 
"assertEquals(queueName, app.getQueue());".
So if someone test  TestRMWebServicesAppsModification with Fair scheduler as 
default scheduler,  it will fail at testAppSubmit.
Now I fix this issue in my new patch YARN-2254.001.patch.
Also based on your suggestion. in my new patch YARN-2254.001.patch, I changed 
TestRMWebServicesAppsModification to make the test parametrized and run it on 
both CapacityScheduler and FairScheduler.
In the future, if someone add new test cases to 
TestRMWebServicesAppsModification, same problem won't happen any more, because 
this unit test will run on FairScheduler also.

> change TestRMWebServicesAppsModification to support FairScheduler.
> ------------------------------------------------------------------
>                 Key: YARN-2254
>                 URL: https://issues.apache.org/jira/browse/YARN-2254
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>            Priority: Minor
>              Labels: test
>         Attachments: YARN-2254.000.patch, YARN-2254.001.patch
> TestRMWebServicesAppsModification skips the test, if the scheduler is not 
> CapacityScheduler.
> change TestRMWebServicesAppsModification to support both CapacityScheduler 
> and FairScheduler.

This message was sent by Atlassian JIRA

Reply via email to