Varun Vasudev updated YARN-2233:

    Attachment: apache-yarn-2233.4.patch

bq.    It seems to me that all API implementations should take the fulll 
principle name if available.

I meant to replace all occurrences of getCallerUserGroupInformation(hsr), if 
that makes sense.

Fixed this. Use the principal everywhere

bq.    We should set all the fields of a DT - token, renewer, expiration-time 
all the time - new-token, renew-token? renewDelegationToken only returns only 
the expiry-time and getToken only returns the token. This is consistent with 
RPCs. But I think in a followup, we should fix this.


bq. You meant we will fix this in a separate JIRA? I still see renewToken not 
returning the entire token info. I'm okay doing it separately, just clarifying 
what you said..

I've fixed this for creating a new delegation token but I didn't fix it for 
renew token. I think it's ok to fix it as part of a seperate JIRA.

> Implement web services to create, renew and cancel delegation tokens
> --------------------------------------------------------------------
>                 Key: YARN-2233
>                 URL: https://issues.apache.org/jira/browse/YARN-2233
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Varun Vasudev
>            Assignee: Varun Vasudev
>            Priority: Blocker
>         Attachments: apache-yarn-2233.0.patch, apache-yarn-2233.1.patch, 
> apache-yarn-2233.2.patch, apache-yarn-2233.3.patch, apache-yarn-2233.4.patch
> Implement functionality to create, renew and cancel delegation tokens.

This message was sent by Atlassian JIRA

Reply via email to