Karthik Kambatla commented on YARN-2244:

bq. Right now the containerLaunchedOnNode code is same as Capacity and Fifo 
with what it does. If we want to unify the code across the schedulers, i would 
prefer leave it like this and then get rid of all three implementations and 
have a single containerLaunchedOnNode in AbstractYarnScheduler instead.

I am not sure if we should punt on re-using existing code to match other 
schedulers. I am open to merging containerLaunchedOnNode across schedulers into 
AbstractYarnScheduler. That is definitely a better solution for this JIRA as 

> FairScheduler missing handling of containers for unknown application attempts 
> ------------------------------------------------------------------------------
>                 Key: YARN-2244
>                 URL: https://issues.apache.org/jira/browse/YARN-2244
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>            Reporter: Anubhav Dhoot
>            Assignee: Anubhav Dhoot
>            Priority: Critical
>         Attachments: YARN-2224.patch, YARN-2244.001.patch, YARN-2244.002.patch
> We are missing changes in patch MAPREDUCE-3596 in FairScheduler. Among other 
> fixes that were common across schedulers, there were some scheduler specific 
> fixes added to handle containers for unknown application attempts. Without 
> these fair scheduler simply logs that an unknown container was found and 
> continues to let it run. 

This message was sent by Atlassian JIRA

Reply via email to