[ 
https://issues.apache.org/jira/browse/YARN-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Junping Du updated YARN-2045:
-----------------------------

    Attachment: YARN-2045-v5.patch

Thanks [~jlowe] for comments! Sorry. I forget to update visibility after 
removing related interfaces from parent abstract class. In v5 patch, I fix most 
of them. Also, I like suggestion to make unit test as a black box which may 
only handle NMStateStore's start and stop. However, in this case, it could 
means we need extra API to update CURRENT_VERSION_INFO which is a constant now 
(but could be changed to different values across different YARN versions) - 
that would bring extra effort and complexity. May be we can keep it is now?

> Data persisted in NM should be versioned
> ----------------------------------------
>
>                 Key: YARN-2045
>                 URL: https://issues.apache.org/jira/browse/YARN-2045
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>    Affects Versions: 2.4.1
>            Reporter: Junping Du
>            Assignee: Junping Du
>         Attachments: YARN-2045-v2.patch, YARN-2045-v3.patch, 
> YARN-2045-v4.patch, YARN-2045-v5.patch, YARN-2045.patch
>
>
> As a split task from YARN-667, we want to add version info to NM related 
> data, include:
> - NodeManager local LevelDB state
> - NodeManager directory structure



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to