Jason Lowe commented on YARN-2045:

Thanks for updating the patch!

bq. Also, I like suggestion to make unit test as a black box which may only 
handle NMStateStore's start and stop. However, in this case, it could means we 
need extra API to update CURRENT_VERSION_INFO which is a constant now (but 
could be changed to different values across different YARN versions)

What I meant is instead of using checkVersion to verify the version we would 
instead stop and start the state store to see if it accepted the version.  We 
would still need to use the storeVersion(NMDBSchemaVersion) package-private 
method to store a custom version after it starts then restart the state store 
to verify it either started up or failed due to an incompatible version.  It's 
not a big deal if you'd rather keep it as-is.

Otherwise latest patch looks good.  Will give it a closer look tomorrow for 
what I think will be final review/commit, and that will also give [~vvasudev] a 
chance to take another look.

> Data persisted in NM should be versioned
> ----------------------------------------
>                 Key: YARN-2045
>                 URL: https://issues.apache.org/jira/browse/YARN-2045
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>    Affects Versions: 2.4.1
>            Reporter: Junping Du
>            Assignee: Junping Du
>         Attachments: YARN-2045-v2.patch, YARN-2045-v3.patch, 
> YARN-2045-v4.patch, YARN-2045-v5.patch, YARN-2045.patch
> As a split task from YARN-667, we want to add version info to NM related 
> data, include:
> - NodeManager local LevelDB state
> - NodeManager directory structure

This message was sent by Atlassian JIRA

Reply via email to