[
https://issues.apache.org/jira/browse/YARN-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066272#comment-14066272
]
Varun Vasudev commented on YARN-2270:
-------------------------------------
[~ajisakaa] your current patch if ok, but maybe we should skip the test if the
ancestor permissions aren't right? If the real issue is the ancestor
permissions, then the get() will fail for all the files. Maybe something like -
{noformat}
boolean ancestorPermissionsOK =
FSDownload.ancestorsHaveExecutePermissions(fs, basedir, null);
assumeTrue(ancestorPermissionsOK);
{noformat}
The benefit of this approach is that the test gets reported as skipped and
people who are interested in ensuring it runs correctly can fix their build
environment to ensure the test runs. Your current approach hides the fact that
the test didn't really do what it was expected to do(apart from the log
message).
> TestFSDownload#testDownloadPublicWithStatCache fails in trunk
> -------------------------------------------------------------
>
> Key: YARN-2270
> URL: https://issues.apache.org/jira/browse/YARN-2270
> Project: Hadoop YARN
> Issue Type: Test
> Affects Versions: 2.4.1
> Reporter: Ted Yu
> Assignee: Akira AJISAKA
> Priority: Minor
> Attachments: YARN-2270.patch
>
>
> From https://builds.apache.org/job/Hadoop-yarn-trunk/608/console :
> {code}
> Running org.apache.hadoop.yarn.util.TestFSDownload
> Tests run: 9, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.955 sec <<<
> FAILURE! - in org.apache.hadoop.yarn.util.TestFSDownload
> testDownloadPublicWithStatCache(org.apache.hadoop.yarn.util.TestFSDownload)
> Time elapsed: 0.137 sec <<< FAILURE!
> java.lang.AssertionError: null
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at
> org.apache.hadoop.yarn.util.TestFSDownload.testDownloadPublicWithStatCache(TestFSDownload.java:363)
> {code}
> Similar error can be seen here:
> https://builds.apache.org/job/PreCommit-YARN-Build/4243//testReport/org.apache.hadoop.yarn.util/TestFSDownload/testDownloadPublicWithStatCache/
> Looks like future.get() returned null.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
