[ 
https://issues.apache.org/jira/browse/YARN-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067844#comment-14067844
 ] 

Hadoop QA commented on YARN-2324:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12656778/YARN-2324.000.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

                  
org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServices
                  
org.apache.hadoop.yarn.server.resourcemanager.security.TestAMRMTokens
                  
org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySched
                  
org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokens
                  
org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification
                  
org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes
                  
org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps
                  
org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesFairScheduler

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/4373//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4373//console

This message is automatically generated.

> Race condition in continuousScheduling for FairScheduler
> --------------------------------------------------------
>
>                 Key: YARN-2324
>                 URL: https://issues.apache.org/jira/browse/YARN-2324
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>         Attachments: YARN-2324.000.patch
>
>
> Race condition in continuousScheduling for FairScheduler.
> removeNode can run when continuousScheduling is called in schedulingThread. 
> If the node is removed from nodes, nodes.get(n2) and 
> getFSSchedulerNode(nodeId) will be null. So we need add lock to remove the 
> NPE/race conditions.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to