Jian He commented on YARN-2295:

patch looks good overall, one comment:
 we can have the newInstance include the following setResource method also.
        LocalResource shellRsrc = LocalResource.newInstance(null,
          LocalResourceType.FILE, LocalResourceVisibility.APPLICATION,
          shellScriptPathLen, shellScriptPathTimestamp);
        try {
          shellRsrc.setResource(ConverterUtils.getYarnUrlFromURI(new URI(

> Refactor YARN distributed shell with existing public stable API
> ---------------------------------------------------------------
>                 Key: YARN-2295
>                 URL: https://issues.apache.org/jira/browse/YARN-2295
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Li Lu
>            Assignee: Li Lu
>         Attachments: TEST-YARN-2295-071514.patch, YARN-2295-071514-1.patch, 
> YARN-2295-071514.patch
> Some API calls in YARN distributed shell have been marked as unstable and 
> private. Use existing public stable API to replace them, if possible. 

This message was sent by Atlassian JIRA

Reply via email to