[
https://issues.apache.org/jira/browse/YARN-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14069994#comment-14069994
]
Zhijie Shen commented on YARN-2229:
-----------------------------------
Some additional comments:
0. For those that have been marked \@Private, it should be okay we break the
backward compatibility. The problem that I can think of is RM and NM versions
are out of sync. For example, RM is 2.6 and it takes the id as a long, while NM
is 2.4 and it takes the id as an int.
1. I'm not sure it's good to makr a \@Stable method back to \@Unstable
{code}
@Public
- @Stable
+ @Unstable
public abstract int getId();
{code}
2. So anyway, we're going to break the users that use protobuf to make the
client in their own programing language, aren't we?
{code}
optional ApplicationAttemptIdProto app_attempt_id = 2;
- optional int32 id = 3;
+ optional int64 id = 3;
}
{code}
> ContainerId can overflow with RM restart
> ----------------------------------------
>
> Key: YARN-2229
> URL: https://issues.apache.org/jira/browse/YARN-2229
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Tsuyoshi OZAWA
> Assignee: Tsuyoshi OZAWA
> Attachments: YARN-2229.1.patch, YARN-2229.10.patch,
> YARN-2229.10.patch, YARN-2229.2.patch, YARN-2229.2.patch, YARN-2229.3.patch,
> YARN-2229.4.patch, YARN-2229.5.patch, YARN-2229.6.patch, YARN-2229.7.patch,
> YARN-2229.8.patch, YARN-2229.9.patch
>
>
> On YARN-2052, we changed containerId format: upper 10 bits are for epoch,
> lower 22 bits are for sequence number of Ids. This is for preserving
> semantics of {{ContainerId#getId()}}, {{ContainerId#toString()}},
> {{ContainerId#compareTo()}}, {{ContainerId#equals}}, and
> {{ConverterUtils#toContainerId}}. One concern is epoch can overflow after RM
> restarts 1024 times.
> To avoid the problem, its better to make containerId long. We need to define
> the new format of container Id with preserving backward compatibility on this
> JIRA.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
