Junping Du commented on YARN-1342:

Thanks [~jlowe] for updating the patch. 
I'd like to continue our practice in YARN-1341 with initiate a question "What 
would happen if failed to update currentMasterKey and previousMasterKey for 
My tentative answer is: staled currentMasterKey won't break anything as it will 
get updated in registering RM during restart. staled previousMasterKey will 
make AM that hold original previousMasterKey failed to start container. Would 
you confirm my understanding is correct? If so, the following code may not be 
+    // if there was no master key, try the previous key
+    if (super.currentMasterKey == null) {
+      super.currentMasterKey = previousMasterKey;
+    }

> Recover container tokens upon nodemanager restart
> -------------------------------------------------
>                 Key: YARN-1342
>                 URL: https://issues.apache.org/jira/browse/YARN-1342
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>    Affects Versions: 2.3.0
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>         Attachments: YARN-1342.patch, YARN-1342v2.patch, 
> YARN-1342v3-and-YARN-1987.patch, YARN-1342v4.patch, YARN-1342v5.patch

This message was sent by Atlassian JIRA

Reply via email to