[ 
https://issues.apache.org/jira/browse/YARN-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14072986#comment-14072986
 ] 

Akira AJISAKA commented on YARN-2336:
-------------------------------------

The patch looks mostly good. I built a pseudo-distributed cluster and verified 
the JSON response.
Some minor comments:
{code}
    FSLeafQueue leaf1 = queueManager.getLeafQueue("root.q.subqueue1", true);
    FSLeafQueue leaf2 = queueManager.getLeafQueue("root.q.subqueue2", true);
{code}
In the test, the above code is only to create LeafQueue and leaf1 and leaf2 are 
unused, so I think it's better to comment that as follows:
{code}
    // create LeafQueue
    queueManager.getLeafQueue("root.q.subqueue1", true);
    queueManager.getLeafQueue("root.q.subqueue2", true);
{code}

{code}
  public void testClusterSchedulerWithSubQueues() throws JSONException, 
Exception {
{code}
Would you render the line within 80 characters?
In addition, would you please remove unused import from 
FairSchedulerQueueInfo.java?

> Fair scheduler REST api returns a missing '[' bracket JSON for deep queue tree
> ------------------------------------------------------------------------------
>
>                 Key: YARN-2336
>                 URL: https://issues.apache.org/jira/browse/YARN-2336
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>    Affects Versions: 2.4.1
>            Reporter: Kenji Kikushima
>            Assignee: Kenji Kikushima
>         Attachments: YARN-2336-2.patch, YARN-2336.patch
>
>
> When we have sub queues in Fair Scheduler, REST api returns a missing '[' 
> blacket JSON for childQueues.
> This issue found by [~ajisakaa] at YARN-1050.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to