[ 
https://issues.apache.org/jira/browse/YARN-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073550#comment-14073550
 ] 

Jian He commented on YARN-2211:
-------------------------------

- This code not needed? may remove the newInstance() method also
{code}
    AMRMTokenSecretManagerState amrmTokenSecretManagerState =
        AMRMTokenSecretManagerState.newInstance();
{code}
- currentKey will never be null ? if so, we can remove the check.
{code} 
if (currentKey != null) {
        this.currentMasterKey =
            new MasterKeyData(currentKey, createSecretKey(currentKey.getBytes()
              .array()));
      }
 if (currentMasterKey != null 
{code}
- Instead of moving the following to yarn_proto, we should probably have a 
separate jira to move all the RM recovery related records to resource manager 
module. For now, I think we can create a new proto file and move amrm token 
state there.{code}
message MasterKeyProto {
  optional int32 key_id = 1;
  optional bytes bytes = 2;
}{code}

> RMStateStore needs to save AMRMToken master key for recovery when RM 
> restart/failover happens 
> ----------------------------------------------------------------------------------------------
>
>                 Key: YARN-2211
>                 URL: https://issues.apache.org/jira/browse/YARN-2211
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-2211.1.patch, YARN-2211.2.patch, YARN-2211.3.patch, 
> YARN-2211.4.patch, YARN-2211.5.1.patch, YARN-2211.5.patch, 
> YARN-2211.6.1.patch, YARN-2211.6.patch
>
>
> After YARN-2208, AMRMToken can be rolled over periodically. We need to save 
> related Master Keys and use them to recover the AMRMToken when RM 
> restart/failover happens



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to