[
https://issues.apache.org/jira/browse/YARN-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074989#comment-14074989
]
Advertising
Karthik Kambatla commented on YARN-1726:
----------------------------------------
Comments on the trunk patch:
# NMSimulator: May be change this signature to match AMSimulator and {{throws
Exception}}
{code}
public void middleStep()
throws YarnException, InterruptedException, IOException {
{code}
# Would the following affect performance? Is there a better alternative, may be
wait-notify?
{code}
while (rmAppAttempt.getAppAttemptState() != RMAppAttemptState.LAUNCHED) {
Thread.sleep(50);
{code}
# In the test, remove the space between in {{count --}}. Also, is there a
reason we have to wait for 45 seconds? Can we use a MockClock to speed this
test up?
> ResourceSchedulerWrapper failed due to the AbstractYarnScheduler introduced
> in YARN-1041
> ----------------------------------------------------------------------------------------
>
> Key: YARN-1726
> URL: https://issues.apache.org/jira/browse/YARN-1726
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 2.4.1
> Reporter: Wei Yan
> Assignee: Wei Yan
> Priority: Blocker
> Attachments: YARN-1726-5.patch, YARN-1726-6-branch2.patch,
> YARN-1726-6.patch, YARN-1726.patch, YARN-1726.patch, YARN-1726.patch,
> YARN-1726.patch
>
>
> The YARN scheduler simulator failed when running Fair Scheduler, due to
> AbstractYarnScheduler introduced in YARN-1041. The ResourceSchedulerWrapper
> should inherit AbstractYarnScheduler, instead of implementing
> ResourceScheduler interface directly.
--
This message was sent by Atlassian JIRA
(v6.2#6252)