[ 
https://issues.apache.org/jira/browse/YARN-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14078840#comment-14078840
 ] 

Hadoop QA commented on YARN-2370:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12658574/YARN-2370.0.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

                  
org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebappAuthentication
                  
org.apache.hadoop.yarn.server.resourcemanager.TestMoveApplication
                  
org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerQueueACLs
                  
org.apache.hadoop.yarn.server.resourcemanager.TestClientRMTokens
                  
org.apache.hadoop.yarn.server.resourcemanager.recovery.TestFSRMStateStore
                  
org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerQueueACLs
                  
org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps
                  
org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService
                  org.apache.hadoop.yarn.server.resourcemanager.TestRMHA
                  
org.apache.hadoop.yarn.server.resourcemanager.TestApplicationACLs

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/4477//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4477//console

This message is automatically generated.

> Fix comment more accurate in AppSchedulingInfo.java
> ---------------------------------------------------
>
>                 Key: YARN-2370
>                 URL: https://issues.apache.org/jira/browse/YARN-2370
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 3.0.0
>            Reporter: Wenwu Peng
>            Assignee: Wenwu Peng
>            Priority: Trivial
>         Attachments: YARN-2370.0.patch
>
>
> in method allocateOffSwitch of AppSchedulingInfo.java, only invoke update 
> OffRack request,  the comment should be "Update cloned OffRack requests for 
> recovery" not "Update cloned RackLocal  and OffRack requests for recover" 
> {code} 
> // Update cloned RackLocal and OffRack requests for recovery
>  resourceRequests.add(cloneResourceRequest(offSwitchRequest));
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to