[ 
https://issues.apache.org/jira/browse/YARN-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14078849#comment-14078849
 ] 

Jian He commented on YARN-2354:
-------------------------------

looks good, checking this in.

> DistributedShell may allocate more containers than client specified after it 
> restarts
> -------------------------------------------------------------------------------------
>
>                 Key: YARN-2354
>                 URL: https://issues.apache.org/jira/browse/YARN-2354
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jian He
>            Assignee: Li Lu
>         Attachments: YARN-2354-072514.patch, YARN-2354-072814.patch, 
> YARN-2354-072914.patch
>
>
> To reproduce, run distributed shell with -num_containers option,
> In ApplicationMaster.java, the following code has some issue.
> {code}
>   int numTotalContainersToRequest =
>         numTotalContainers - previousAMRunningContainers.size();
>     for (int i = 0; i < numTotalContainersToRequest; ++i) {
>       ContainerRequest containerAsk = setupContainerAskForRM();
>       amRMClient.addContainerRequest(containerAsk);
>     }
>     numRequestedContainers.set(numTotalContainersToRequest);
> {code}
>  numRequestedContainers doesn't account for previous AM's requested 
> containers. so numRequestedContainers should be set to numTotalContainers



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to