[ https://issues.apache.org/jira/browse/YARN-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14080540#comment-14080540 ]
Wenwu Peng commented on YARN-1572: ---------------------------------- Not sure the rackLocalRequest is cause of NPE, Better to check rackLocalRequest whether is null before rackLocalRequest.setNumContainers {code} ResourceRequest rackLocalRequest = requests.get(priority).get(node.getRackName()); rackLocalRequest.setNumContainers(rackLocalRequest.getNumContainers() - 1); {code} > Low chance to hit NPE issue in AppSchedulingInfo#allocateNodeLocal > ------------------------------------------------------------------ > > Key: YARN-1572 > URL: https://issues.apache.org/jira/browse/YARN-1572 > Project: Hadoop YARN > Issue Type: Bug > Components: scheduler > Affects Versions: 2.2.0 > Reporter: Wenwu Peng > Assignee: Junping Du > Attachments: conf.tar.gz, log.tar.gz > > > we have lower chance to hit NPE in allocateNodeLocal when run benchmark(hit > 4 in 20 times). > Steps: > 1. setup hadoop 2.2.0 environment > 2. Run for i in {1..10}; do /hadoop/hadoop-smoke/bin/hadoop jar > /hadoop/hadoop-smoke/share/hadoop/mapreduce/hadoop-mapreduce-client-common-*.jar > org.apache.hadoop.fs.TestDFSIO -write -nrFiles 30 -fileSize 64MB; sleep > 10;done > 2014-01-08 03:56:14,082 FATAL > org.apache.hadoop.yarn.server.resourcemanager.ResourceManager: Error in > handling event type NODE_UPDATE to the scheduler > java.lang.NullPointerException > at > org.apache.hadoop.yarn.server.resourcemanager.scheduler.AppSchedulingInfo.allocateNodeLocal(AppSchedulingInfo.java:291) > at > org.apache.hadoop.yarn.server.resourcemanager.scheduler.AppSchedulingInfo.allocate(AppSchedulingInfo.java:252) > at > org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp.allocate(FiCaSchedulerApp.java:294) > at > org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo.FifoScheduler.assignContainer(FifoScheduler.java:614) > at > org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo.FifoScheduler.assignNodeLocalContainers(FifoScheduler.java:524) > at > org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo.FifoScheduler.assignContainersOnNode(FifoScheduler.java:482) > at > org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo.FifoScheduler.assignContainers(FifoScheduler.java:419) > at > org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo.FifoScheduler.nodeUpdate(FifoScheduler.java:658) > at > org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo.FifoScheduler.handle(FifoScheduler.java:687) > at > org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo.FifoScheduler.handle(FifoScheduler.java:95) > at > org.apache.hadoop.yarn.server.resourcemanager.ResourceManager$SchedulerEventDispatcher$EventProcessor.run(ResourceManager.java:440) > at java.lang.Thread.run(Thread.java:662) > will attach log and configure files later > Note: > My topology file: > 10.111.89.230 /QE1/sin2-pekaurora-bdcqe046.eng.vmware.com > 10.111.89.231 /QE1/sin2-pekaurora-bdcqe046.eng.vmware.com > 10.111.89.232 /QE1/sin2-pekaurora-bdcqe046.eng.vmware.com > 10.111.89.239 /QE1/sin2-pekaurora-bdcqe046.eng.vmware.com > 10.111.89.233 /QE1/sin2-pekaurora-bdcqe017.eng.vmware.com > 10.111.89.234 /QE1/sin2-pekaurora-bdcqe017.eng.vmware.com > 10.111.89.240 /QE1/sin2-pekaurora-bdcqe017.eng.vmware.com > 10.111.89.236 /QE2/sin2-pekaurora-bdcqe047.eng.vmware.com > 10.111.89.241 /QE2/sin2-pekaurora-bdcqe047.eng.vmware.com > 10.111.89.238 /QE2/sin2-pekaurora-bdcqe048.eng.vmware.com > 10.111.89.242 /QE2/sin2-pekaurora-bdcqe048.eng.vmware.com -- This message was sent by Atlassian JIRA (v6.2#6252)