[ 
https://issues.apache.org/jira/browse/YARN-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14080934#comment-14080934
 ] 

Junping Du commented on YARN-2051:
----------------------------------

+1. Patch looks good to me. Will commit it tomorrow if no more feedback from 
others.

> Fix code bug and add more unit tests for PBImpls
> ------------------------------------------------
>
>                 Key: YARN-2051
>                 URL: https://issues.apache.org/jira/browse/YARN-2051
>             Project: Hadoop YARN
>          Issue Type: Test
>            Reporter: Junping Du
>            Assignee: Binglin Chang
>            Priority: Critical
>         Attachments: YARN-2051.v1.patch, YARN-2051.v2.patch
>
>
> From YARN-2016, we can see some bug could exist in PB implementation of 
> protocol. The bad news is most of these PBImpl don't have any unit test to 
> verify the info is not lost or changed after serialization/deserialization. 
> We should add more tests for it.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to