[ 
https://issues.apache.org/jira/browse/YARN-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087860#comment-14087860
 ] 

Hadoop QA commented on YARN-2352:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12660151/yarn-2352-2.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 2 new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-common-project/hadoop-common 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

                  org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/4537//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-YARN-Build/4537//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4537//console

This message is automatically generated.

> FairScheduler: Collect metrics on duration of critical methods that affect 
> performance
> --------------------------------------------------------------------------------------
>
>                 Key: YARN-2352
>                 URL: https://issues.apache.org/jira/browse/YARN-2352
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: scheduler
>    Affects Versions: 2.4.1
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: fs-perf-metrics.png, yarn-2352-1.patch, 
> yarn-2352-2.patch, yarn-2352-2.patch
>
>
> We need more metrics for better visibility into FairScheduler performance. At 
> the least, we need to do this for (1) handle node events, (2) update, (3) 
> compute fairshares, (4) preemption.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to