Sandy Ryza commented on YARN-2352:

IIUC, this patch will only record the duration.  If we go that route, I think 
we should call these metrics lastNodeUpdateDuration etc..  However, would it 
make sense to go with an approach that records more historical information?  
For example, RPCMetrics uses a MutableRate to keep stats on the processing time 
for RPCs, and I think a similar model could work here.

Last, is there any need to make the FSPerfMetrics instance static?  Right now I 
think the Fair Scheduler has managed to avoid any mutable static variables. 

> FairScheduler: Collect metrics on duration of critical methods that affect 
> performance
> --------------------------------------------------------------------------------------
>                 Key: YARN-2352
>                 URL: https://issues.apache.org/jira/browse/YARN-2352
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: scheduler
>    Affects Versions: 2.4.1
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: fs-perf-metrics.png, yarn-2352-1.patch, 
> yarn-2352-2.patch, yarn-2352-2.patch
> We need more metrics for better visibility into FairScheduler performance. At 
> the least, we need to do this for (1) handle node events, (2) update, (3) 
> compute fairshares, (4) preemption.

This message was sent by Atlassian JIRA

Reply via email to